JuliaDataCubes / JuliaDataCubes/YAXArrays.jl

Type mismatch for cubes with missing values

Open
#185 0 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Julia
Stars
132
Forks
25
PR merge metrics
No merged PRs in 30d

Description

I found the source of the type mismatch of opening the esdc or opening it directly from a path.

In the esdc function we use zopen to open the path to the esdc which returns a ZGroup which is then converted into a ZarrDataset by the open_dataset function.

When we use the string directly we use the ZarrDataset method for string inputs in YAXArrayBase which is defined here:
https://github.com/JuliaDataCubes/YAXArrayBase.jl/blob/1f91f2ef52fe4943da4af01dcc20df4694116c1c/src/datasets/zarr.jl#L7
with the following definition

ZarrDataset(g::String;mode="r") = ZarrDataset(zopen(g,mode,fill_as_missing=false))

Therefore, we call here zopen with fill_as_missing as false and therefore do not get the Union{T, Missing} as type information.
For now you can just open the data with the Cube(open_dataset(zopen(path))).
This is related to #181.

@meggart @gdkrmr

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with src/datasets/zarr.jl, especially the ZarrDataset string constructor, and compare its zopen options with the esdc/open_dataset path described in the issue. Verify that opening the same data either way preserves the missing-value type information and that the resulting Cube construction no longer has a type mismatch.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
data
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.