JuliaDataCubes / JuliaDataCubes/PyramidScheme.jl

Pyramid from DimArray without Lookups not possible

Open
#66 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Julia
Stars
18
Forks
3
PR merge metrics
No merged PRs in 30d

Description

I am not sure, whether this should be possible, but I just realized this and I get the following error:

julia> pyr = Pyramid(DimArray(img, (X,Y)))
ERROR: MethodError: no method matching DimensionalData.Dimensions.Lookups.NoLookup(::LinRange{Float64, Int64})
The type `DimensionalData.Dimensions.Lookups.NoLookup` exists, but no method is defined for this combination of argument types when trying to construct it.

Closest candidates are:
  DimensionalData.Dimensions.Lookups.NoLookup()
   @ DimensionalData ~/Documents/FAIRSENDD/worldmap/dev/DimensionalData/src/Lookups/lookup_arrays.jl:158
  DimensionalData.Dimensions.Lookups.NoLookup(::A) where A<:AbstractVector{Int64}
   @ DimensionalData ~/Documents/FAIRSENDD/worldmap/dev/DimensionalData/src/Lookups/lookup_arrays.jl:156

Stacktrace:
  [1] rebuild(l::DimensionalData.Dimensions.Lookups.NoLookup{…}; data::LinRange{…}, kw::@Kwargs{…})
    @ DimensionalData.Dimensions.Lookups ~/Documents/FAIRSENDD/worldmap/dev/DimensionalData/src/Lookups/lookup_arrays.jl:160
  [2] _set(lookup::DimensionalData.Dimensions.Lookups.NoLookup{Base.OneTo{Int64}}, values::LinRange{Float64, Int64})
    @ DimensionalData.Dimensions.Lookups ~/Documents/FAIRSENDD/worldmap/dev/DimensionalData/src/Lookups/set.jl:50
  [3] _set(dim::X{DimensionalData.Dimensions.Lookups.NoLookup{Base.OneTo{Int64}}}, x::LinRange{Float64, Int64})
    @ DimensionalData.Dimensions ~/Documents/FAIRSENDD/worldmap/dev/DimensionalData/src/Dimensions/set.jl:38
  [4] set(dim::X{DimensionalData.Dimensions.Lookups.NoLookup{Base.OneTo{Int64}}}, x::LinRange{Float64, Int64})
    @ DimensionalData.Dimensions ~/Documents/FAIRSENDD/worldmap/dev/DimensionalData/src/Dimensions/set.jl:5
  [5] agg_axis(d::X{DimensionalData.Dimensions.Lookups.NoLookup{Base.OneTo{Int64}}}, n::Int64)
    @ PyramidScheme ~/Documents/FAIRSENDD/worldmap/dev/PyramidScheme/src/PyramidScheme.jl:278
  [6] _broadcast_getindex_evalf
    @ ./broadcast.jl:673 [inlined]
  [7] _broadcast_getindex
    @ ./broadcast.jl:646 [inlined]
  [8] (::Base.Broadcast.var"#17#18"{Base.Broadcast.Broadcasted{…}})(k::Int64)
    @ Base.Broadcast ./broadcast.jl:1097
  [9] ntuple
    @ ./ntuple.jl:49 [inlined]
 [10] copy
    @ ./broadcast.jl:1097 [inlined]
 [11] materialize
    @ ./broadcast.jl:867 [inlined]
 [12] (::PyramidScheme.var"#39#41"{Tuple{X{…}, Y{…}}})(i::Int64)
    @ PyramidScheme ./none:0
 [13] iterate
    @ ./generator.jl:48 [inlined]
 [14] collect
    @ ./array.jl:791 [inlined]
 [15] getpyramids(reducefunc::Function, ras::DimMatrix{…}; recursive::Bool)
    @ PyramidScheme ~/Documents/FAIRSENDD/worldmap/dev/PyramidScheme/src/PyramidScheme.jl:394
 [16] getpyramids
    @ ~/Documents/FAIRSENDD/worldmap/dev/PyramidScheme/src/PyramidScheme.jl:386 [inlined]
 [17] Pyramid(data::DimMatrix{…}; resampling_method::Function, kwargs::@Kwargs{})
    @ PyramidScheme ~/Documents/FAIRSENDD/worldmap/dev/PyramidScheme/src/PyramidScheme.jl:46
 [18] Pyramid(data::DimMatrix{…})
    @ PyramidScheme ~/Documents/FAIRSENDD/worldmap/dev/PyramidScheme/src/PyramidScheme.jl:45
 [19] top-level scope
    @ REPL[15]:1
Some type information was truncated. Use `show(err)` to see complete types.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce Pyramid(DimArray(img, (X,Y))) and confirm the NoLookup MethodError. Read src/PyramidScheme.jl around agg_axis at line 278 and getpyramids at lines 386-394, then inspect the DimensionalData lookup code in lookup_arrays.jl and set.jl named in the stack trace. Done means the intended behavior for a DimArray without lookups is established and the construction no longer fails unexpectedly.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
data-visualization
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.