JuliaDataCubes / JuliaDataCubes/EarthDataLab.jl

Cubefromshape includes surrounded outer

Open
#235 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Triage
Dominant language
Julia
Stars
34
Forks
14
PR merge metrics
No merged PRs in 30d

Description

When I have a ring shaped shapefile, the cubefromshape function includes the surrounded area as internal to the shapefile.
In this example the pink area is my shapefile and the black area is the exported cube which I generated with the cubefromshape function.
We see, that the outer boundaries align quite well, but the inner area shouldn't be included in the rasterization.

Screenshot from 2020-12-10 15-00-57

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the cubefromshape function and tracing how a ring-shaped shapefile is rasterized. Reproduce the example described in the issue and inspect the generated cube against the shapefile's outer and inner boundaries. Done means the surrounded inner area is excluded while the outer boundary remains aligned.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
data
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.