JuliaData / JuliaData/WeakRefStrings.jl
Constructor should make a copy
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 22
- Forks
- 20
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 1
Description
The following constructor should make a copy:
https://github.com/JuliaData/WeakRefStrings.jl/blob/7da08fd778ed784e0ec3f96ef1981dca975891c0/src/WeakRefStrings.jl#L289
This is not a problem in practice when the input is not a StringArray since a new array will have to be allocated, but we should add a method calling copy for StringArray inputs.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at src/WeakRefStrings.jl around line 289 and inspect the constructor's handling of StringArray inputs. Confirm the expected copy behavior with a focused test: changing the original input after construction should not change the constructed value.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- data
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100