JuliaData / JuliaData/SplitApplyCombine.jl
possible to open up types on`innerjoin`?
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 154
- Forks
- 16
- PR merge metrics
- No merged PRs in 30d
Description
It looks like the functions given to innerjoin need to be Union{Function, Type}, which precludes callable objects. Would it be possible to remove that restriction?
For some local code I defined (name::Symbol)(x) = getfield(x, name), so I don't have to do so many r->r.foo and can instead just do things like map(:foo, coll), etc. It doesn't work with innerjoin though.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the innerjoin entry point and inspect how the Union{Function, Type} restriction is declared. Reproduce the issue with a callable object like the Symbol-based example, then verify that innerjoin accepts it while preserving existing behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- data
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100