JuliaData / JuliaData/SentinelArrays.jl
`replace[!]()` with `count` is broken
Open
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 22
- Forks
- 19
- PR merge metrics
- No merged PRs in 30d
Description
replace as well as replace! do not work properly if count is supplied:
julia> replace(ChainedVector([[1,2],[1,2]]), 2=>20; count=1)
6-element ChainedVector{Int64, Vector{Int64}}:
1
20
1
20
julia> replace([1,2,1,2],1=>20,count=1) # expectation
4-element Vector{Int64}:
20
2
1
2
The underlying code just applies the count limitation to each chunk.
Sprinkeling @inbounds on the array get/setindex didn't improve performance, but I should probably add it.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the replace and replace! entry points for ChainedVector and the underlying chunk-processing code. Verify how count is applied across chunks, then add coverage showing that count limits total replacements and confirm both functions match the documented expectation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- data
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100