JuliaData / JuliaData/PooledArrays.jl
bug with empty constructors
Open
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 49
- Forks
- 11
- PR merge metrics
- No merged PRs in 30d
Description
In src/PooledArrays.jl at lines 202-203, we find the following code
@inline PooledArray(t::Type) = PooledArray(Array(t,0))
@inline PooledArray(t::Type, r::Type) = PooledArray(Array(t,0), r)
which does not work as there is no method Array(::Type,::Int).
I guess the intent was more like Array{t}(undef,0) (or just t[]) instead of Array(t,0).
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/PooledArrays.jl at lines 202-203 and inspect the two empty-constructor methods. Verify the appropriate Julia syntax for creating a zero-length array and confirm that both constructors work without the reported Array(::Type, ::Int) method error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- data
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100