JuliaData / JuliaData/PooledArrays.jl
DataAPI.levels method?
Open
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 49
- Forks
- 11
- PR merge metrics
- No merged PRs in 30d
Description
In the Arrow.jl package we added a method
function DataAPI.levels(x::DictEncoded)
rp = DataAPI.refpool(x) # may contain missing values
Missing <: eltype(rp) || return rp
convert(AbstractArray{nonmissingtype(eltype(rp))}, deleteat!(rp, ismissing.(rp)))
end
Should there be a similar method for PooledArray?
At present the default method for levels ends up sorting the pool.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by examining the existing DataAPI.levels method for DictEncoded and the default levels behavior for PooledArray. Determine whether PooledArray should expose its pool without sorting, including how missing values are handled; done means the behavior is agreed and covered for the relevant cases.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- data
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100