JuliaData / JuliaData/DataFramesMeta.jl
Bug with `@where true`
Open
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 496
- Forks
- 56
- PR merge metrics
- No merged PRs in 30d
Description
When we have @where true, true is not a QuoteNode or a Expr. We don't have a method for it.
We should fix this, combined with #253 to just return Return(x) for anything not an expression, i.e. string, ints, or booleans.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting the implementation and tests for the @where macro, then compare this issue with #253. Trace how literal values such as true, strings, and integers are handled; done means non-expression inputs return Return(x) and the relevant behavior is covered by passing tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- data
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100