JuliaData / JuliaData/DataFrames.jl
Add options to `join` missing error?
Open
Nobody has claimed this yet.
doc
feature
- Dominant language
- Julia
- Stars
- 1.8k
- Forks
- 372
- Avg merge
- 5d 7h
- Merged PRs (30d)
- 5
Description
Currently we have an ArgumentError when matchmissing==:error and there are missings. Almost every time I run into this I have to look up what the other options are called. Could we change the error from:
ArgumentError: Missing values in key columns are not allowed when matchmissing == :error. `missing` found in column :x in left data frame.
to:
ArgumentError: Missing values in key columns are not allowed when matchmissing == :error. `missing` found in column :x in left data frame. To perform a join with missing values choose `matchmissing = :equal` or `:notequal`.
or similar?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file or test is named in the issue. Start by searching the JuliaData/DataFrames.jl source for the existing ArgumentError text and the matchmissing == :error join path. Done means the error explains the available :equal and :notequal options, with the relevant tests updated if present.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- data
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100