JuliaControl / JuliaControl/ControlSystems.jl
lsim and lsimplot has problems with arguments u and x0
Open
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 582
- Forks
- 92
- Avg merge
- 1h 12m
- Merged PRs (30d)
- 2
Description
See https://discourse.julialang.org/t/controlsystems-transfer-functions-with-delay/58003/7
- Inconsistency between normal and delayed systems in how
uis defined,u(x, t)vsu(t). Can easily lead to defining a zero input since delay system also acceptu(uout, t)as an inplace version. - Missing documentation in the online docs about
lsimfor delayed systems, exists inhelp?>menu in repl - Does not handle different types for
x0, for example ifsysis float andx0is int array lsimplotcan't handlex0at all and gives strange error message- Not very clear what the states are, i.e. how the delay enters the system. This is important when setting the initial state
x0. It is also not very clear how the delayed states are initialized and how you can affect them (not really possible as it is now but maybe it should be).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the lsim and lsimplot entry points, then compare the delayed-system guidance in the online documentation with the help? text. Done means the u and x0 behavior is consistent and documented, lsimplot handles x0, and the state and delayed-state initialization semantics are clear.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100