JuliaControl / JuliaControl/ControlSystems.jl
Use of promote_op problematic
Open
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 582
- Forks
- 92
- Avg merge
- 1h 12m
- Merged PRs (30d)
- 2
Description
See discussion in https://github.com/JuliaLang/julia/issues/38436#issuecomment-730200157
We should try to rid ourselves of the use of promote_op to avoid future situations like this.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the linked discussion in JuliaLang/julia issue 38436, especially comment 730200157, to understand why promote_op is problematic. Then locate the repository's uses of promote_op and determine the scope of replacing them; done means future situations of this kind are avoided without changing control-system behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100