JuliaCollections / JuliaCollections/FunctionalCollections.jl
conj is a pun
Open
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 126
- Forks
- 33
- PR merge metrics
- No merged PRs in 30d
Description
conj(s::PersistentSet{T}, val) should not overload Base.conj.
Base.conj is complex conjugation.
I suggest replacing it with push.
We already provide push as an alias for conj.
push is a good name since push!(::Set, val) is how you add one element to a Base.Set
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the PersistentSet implementation and its existing push alias, then inspect references to conj and push across the repository. Confirm the intended public API and update the affected behavior and tests so adding an element uses push without overloading Base.conj.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- backend-api-design
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100