JuliaCollections / JuliaCollections/FunctionalCollections.jl
`filter` on `PersistentHashMap` inconsistent with `Base`
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 126
- Forks
- 33
- PR merge metrics
- No merged PRs in 30d
Description
The Base version of filter on Dict requires a function that takes two arguments. That's not the case for PersistentHashMap. Arguably, the existing FunctionalCollections behaviour makes more sense; I've filed https://github.com/JuliaLang/julia/issues/17886 over in Base. If Base transitions to one-argument, then nothing needs to be done; otherwise, I feel like PersistentHashMap must be changed too to avoid the surprise factor.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing the Base Dict filter contract with PersistentHashMap and the existing FunctionalCollections behavior. Read Julia issue #17886 to determine whether Base will change; done means either no change is needed or PersistentHashMap is aligned with the settled Base behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- data
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100