JuliaCollections / JuliaCollections/FunctionalCollections.jl
Consider `setindex` for `assoc`
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 126
- Forks
- 33
- PR merge metrics
- No merged PRs in 30d
Description
FixedSizeArrays uses setindex to mean what assoc does in this package. Personally, I find setindex more consistent. I don't have any opinion as to whether assoc should be kept or deprecated (note that setindex has opposite argument order).
Perhaps a new package can be spun off with definitions for non-mutating versions of Base functions, and packages like FunctionalCollections can extend those. In particular, it would be useful to make push, append, and the like extensible by other packages without requiring a dependency on FunctionalCollections. But that's a different issue.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing FixedSizeArrays' setindex convention with FunctionalCollections' assoc API, including the opposite argument order. Resolve whether assoc should be retained or deprecated; the proposed package split and extensible non-mutating Base functions are described as a separate issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- data
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100