JuliaCollections / JuliaCollections/DataStructures.jl

AVL Tree search is "slow"

Open
#956 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Julia
Stars
745
Forks
261
PR merge metrics
No merged PRs in 30d

Description

Hello,

AVL tree integration in DataStructures.jl was discussed in #503 but it seems that this implementation is slow (especially for search operation).

See benchmark https://github.com/femtotrader/AVLTreeBenchmarks.jl/ for a comparison with @krynju implementation https://github.com/krynju/AVLTrees.jl and discussion https://github.com/p-casgrain/LimitOrderBook.jl/issues/7 (LimitOrderBook.jl from @p-casgrain )

Best regards,
Femto

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the AVLTreeBenchmarks.jl benchmark linked in the issue and inspect the DataStructures.jl AVL tree implementation it exercises. Compare search results with the referenced AVLTrees.jl and LimitOrderBook.jl discussions; done means the AVL search performance is measurably improved and the benchmark demonstrates the change.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
data, performance
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.