JuliaCollections / JuliaCollections/DataStructures.jl

searchsortedbefore - reverse of searchsortedafter

Open
#879 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Julia
Stars
745
Forks
261
PR merge metrics
No merged PRs in 30d

Description

For sorted containers, it'd be nice if there was a function analogous to searchsortedafter that instead got the token of the last item that is < a given key. In more detail, searchsortedfirst (first item >= key) is to searchsortedafter (first item > key) as searchsortedlast (last item <= key) would be to... searchsortedbefore? That'd probably be an appropriate name.
I'm willing to write a PR if there's interest in this. Seems like it'd be very simple considering prevloc0 is available in the internals. Thoughts?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the sorted-container implementations and the existing searchsortedfirst, searchsortedlast, searchsortedafter, and prevloc0 entry points mentioned in the issue. Trace how searchsortedafter handles boundary positions, then define the matching searchsortedbefore behavior and verify it across keys before, between, and after stored items.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
data
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.