JuliaCollections / JuliaCollections/DataStructures.jl
Allow passing arbitrary Integers to methods for IntDisjointSets
Open
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 745
- Forks
- 261
- PR merge metrics
- No merged PRs in 30d
Description
I noticed that some methods for IntDisjointSets are defined such that they only allow the exact eltype as parameter, for example
"""
in_same_set(s::IntDisjointSet{T}, x::T, y::T)
Returns `true` if `x` and `y` belong to the same subset in `s`, and `false` otherwise.
"""
in_same_set(s::IntDisjointSet{T}, x::T, y::T) where {T<:Integer} = find_root!(s, x) == find_root!(s, y)
Would be a good idea to change these methods to something like
in_same_set(s::IntDisjointSet{T}, x::Integer, y::Integer) where {T<:Integer} = find_root!(s, T(x)) == find_root!(s, T(y))
?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the IntDisjointSet methods, including the in_same_set entry point shown in the issue, and inspect which methods currently require the exact element type. Determine the complete set of affected methods and verify that accepting other Integer values preserves the existing behavior after conversion to the set's type.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- data
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100