JuliaCollections / JuliaCollections/DataStructures.jl

`PriorityQueue` does not wrap `BinaryHeap`

Open
#761 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Julia
Stars
745
Forks
261
PR merge metrics
No merged PRs in 30d

Description

I wonder why PriorityQueue does not wrap a BinaryHeap as one of its fields, but rather implements a binary heap and associated methods from scratch. Would a refactoring make sense or? This may also facilitate addressing #742 at least for this type. Apologies if this is a duplicate.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading src/priorityqueue.jl around lines 28-29 to compare PriorityQueue's implementation with the referenced BinaryHeap, then review issue #742 for the related motivation. Determine whether wrapping BinaryHeap is feasible and what behavior or APIs must remain compatible; done means an agreed refactoring scope, since the issue does not specify a concrete change.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
tooling
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.