JuliaCollections / JuliaCollections/DataStructures.jl
Should SortedSet convert the key in the `in` function?
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 745
- Forks
- 261
- PR merge metrics
- No merged PRs in 30d
Description
I have been working with ShortStrings.jl a bit lately.
It seems like it should not be required for in(::ShortString, ::SortedSet(String) to internally convert the ShortString to a String.
cmp is defined already between those types.
cc @StephenVavasis
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the SortedSet implementation and its in(::ShortString, ::SortedSet(String)) path, then inspect the existing cmp definitions between ShortString and String. Confirm the expected membership behavior and add coverage showing that a ShortString key can be checked in a SortedSet of Strings without an internal conversion.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- data
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100