JuliaCollections / JuliaCollections/DataStructures.jl

Make queue and stack immutable structs

Open
#587 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Julia
Stars
745
Forks
261
PR merge metrics
No merged PRs in 30d

Description

Currently, queue and stack are both just wrappers around a dequeue. Apparently these wrappers are mutable structs. Would it make sense, to make them immutable? I don't see any use case, where someone should be able to exchange the wrapped dequeue.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the queue and stack definitions and how they wrap dequeue. Read their existing usages and tests, if present, to determine whether replacing mutable wrappers with immutable structs preserves the public API. Done means the design decision is implemented consistently and the existing behavior remains covered by passing tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
data
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.