JuliaCollections / JuliaCollections/DataStructures.jl
Missing constructor for DisjointSets
Open
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 745
- Forks
- 261
- PR merge metrics
- No merged PRs in 30d
Description
julia> DisjointSets([1, 2, 3])
ERROR: MethodError: no method matching DisjointSets(::Array{Int64,1})
Stacktrace:
[1] top-level scope at REPL[2]:1
julia> DisjointSets{Int}([1, 2, 3])
DisjointSets{Int64}(Dict(2 => 2,3 => 3,1 => 1), [1, 2, 3], IntDisjointSets([1, 2, 3], [0, 0, 0], 3))
There doesn't seem to be any reason not to have a constructor
DataStructures(v::Vector{T}) where {T} = DisjointSets{T}(v)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the DisjointSets constructors and compare the untyped vector call with DisjointSets{Int}([1, 2, 3]). Verify the requested convenience constructor in the Julia REPL; done means DisjointSets([1, 2, 3]) works and produces the same structure as the typed call.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- data
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100