JuliaCollections / JuliaCollections/DataStructures.jl
add normalize(::Accumulator, p)
Open
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 745
- Forks
- 261
- PR merge metrics
- No merged PRs in 30d
Description
Sometimes when I count things, I am more interested in percentages than absolute values. I wonder if you would consider a PR along the lines of
function Base.normalize{T,V}(acc::Accumulator{T,V}, p=1)
_norm = norm(collect(values(acc)), p)
Accumulator(Dict(key => value/_norm for (key,value) in acc.map))
end
(obviously with documentation, tests, etc).
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the Accumulator implementation and its existing documentation and tests, then review the proposed Base.normalize signature and its handling of p. Done means Accumulator supports normalization to percentages with documented behavior and tests covering the new method.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- data
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100