JuliaCollections / JuliaCollections/DataStructures.jl

Deprecate compare in favor of lt and Ordering from Base?

Open
#243 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Julia
Stars
745
Forks
261
PR merge metrics
No merged PRs in 30d

Description

In Base and elsewhere, the preferred way of doing comparisons as is done here with compare and Comp is through lt with Base.Order. Thus I propose that, for consistency, this package be updated to deprecate its own comparison functionality in favor of that from Base. If this seems like a good idea, I can submit a PR.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating this package's comparison entry points, especially compare and Comp, then compare their role with Base.lt and Base.Order. Define which functionality should be deprecated and what consistent replacement the package should document or expose; the issue does not identify files or tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
data
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.