JuliaCollections / JuliaCollections/AbstractTrees.jl

Remove the `String` type constraint in `TreeCharSet`?

Open
#112 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Julia
Stars
243
Forks
67
PR merge metrics
No merged PRs in 30d

Description

I'd like to customize the color of those characters in TreeCharSet with https://github.com/KristofferC/Crayons.jl . But the type is constrained to String currently. (I remember it was not in prior minor versions). Although I can use the transformed string representation, the textwidth would get the wrong number of text width in that case.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the TreeCharSet implementation and the code that applies its String constraint, then inspect how Crayons.jl-colored characters are represented and how textwidth is calculated. The change is complete when TreeCharSet accepts the intended colored character values without producing incorrect display widths, with coverage for the relevant rendering behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
cli
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.