JuliaCI / JuliaCI/BenchmarkTools.jl
Remove vector indexing in favor of foldl
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 684
- Forks
- 107
- PR merge metrics
- No merged PRs in 30d
Description
BenchmarkGroups currently implements an indexing scheme where a key vector indicates nested indexing. This can and should be removed in favor of using foldl(getindex, g::BenchmarkGroup, keys) (ref here).
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating BenchmarkGroups and the vector-indexing implementation described in doc/manual.md under indexing into a BenchmarkGroup. Read the linked Julia discussion about foldl(getindex, g::BenchmarkGroup, keys), then identify the documentation and tests that cover vector indexing. Done means the old indexing scheme is removed in favor of foldl-based lookup and the affected documentation and tests reflect that change.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100