JuliaCI / JuliaCI/BenchmarkTools.jl
Clarification questions on design
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 684
- Forks
- 107
- PR merge metrics
- No merged PRs in 30d
Description
I am trying to read into the comment:
https://github.com/JuliaCI/BenchmarkTools.jl/blob/45052b1953029a0bfd0829ab735dd055d01d9676/src/execution.jl#L268-L270
Is this to allow tune!ing benchmarks as a separate step from running them?
At the risk of being further off-topic, I'm trying to understand what is happening with allocations here:
https://github.com/KristofferC/NearestNeighbors.jl/blob/73eeb606efb504cd0638fd3f4eb5dd2cd025296d/benchmarks/runbenchmarks.jl#L24
If I understand correctly, for each loop iteration, there is a new reference to a different tree "instances", and there is memory allocated for each of those. If that's the case, then it seems it might be beneficial to interleave this with running the benchmarks. But I'm not sure how to organize that.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading src/execution.jl at lines 268-270 and the linked NearestNeighbors.jl benchmarks/runbenchmarks.jl at line 24. Determine whether tuning and running are intended as separate steps and how allocations relate to the benchmark loop; done would require a documented clarification of these design questions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- performance, testing-qa
- Issue type
- Documentation
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100