JuliaAstro / JuliaAstro/AstroTime.jl

GPS epoch

Open
#69 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Julia
Stars
38
Forks
11
PR merge metrics
No merged PRs in 30d

Description

This package helpfully defines GPS_EPOCH here
https://github.com/JuliaAstro/AstroTime.jl/blob/a891ffef6fb142d37b8f8836b3ec75da4955606d/src/Epochs/epoch_constants.jl#L7

However, I think it's incorrect to define it in TT. It should be 1980-01-06 UTC according to wikipedia and also section 11.4.3.3 of the manual from the US Coast Guard. So the definition should be equivalent to from_utc(1980,1,6) or TAIEpoch(1980, 1, 6, 0, 0, 19.0).

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in src/Epochs/epoch_constants.jl at line 7, then inspect the existing from_utc and TAIEpoch APIs used to represent epochs. Verify GPS_EPOCH against the UTC date and the equivalent TAI value given in the issue. Done means the constant represents 1980-01-06 UTC consistently with those APIs.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.