JuliaArrays / JuliaArrays/StructArrays.jl
Ambiguity issue in broadcasting.
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 402
- Forks
- 49
- PR merge metrics
- No merged PRs in 30d
Description
This came up in https://github.com/rafaqz/DimensionalData.jl/issues/1195
Essentially, it appears that StructArrays is defining its Broadcasting precedence incorrectly. The Julia interface's docs for binary broadcasting rules make this pretty clear https://docs.julialang.org/en/v1/manual/interfaces/#writing-binary-broadcasting-rules
It looks like essentially we should delete this line of code https://github.com/JuliaArrays/StructArrays.jl/blob/4a1e271029b3c562bcff5056f1a861a24a76eb3e/src/structarray.jl#L537
I'll make a PR shortly that removes this and examine what, if anything, breaks.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with src/structarray.jl around line 537 and read the linked Julia broadcasting rules and DimensionalData.jl issue for the failing context. Check the existing broadcasting tests or reproduce the reported ambiguity, then run the test suite to confirm the precedence behavior is corrected without regressions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- data
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 50/100