JuliaArrays / JuliaArrays/StaticArrays.jl

`StaticArrays.SUnitRange <: AbstractUnitRange` should be `true`?

Open
#978 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Julia
Stars
844
Forks
159
Avg merge
3d 21h
Merged PRs (30d)
3

Description

Here's a small example.

julia> Base.OneTo <: AbstractUnitRange
true

julia> Base.UnitRange <: AbstractUnitRange
true

julia> StaticArrays.SOneTo <: AbstractUnitRange
true

julia> StaticArrays.SUnitRange <: AbstractUnitRange
false

Related comment: https://github.com/JuliaArrays/StaticArrays.jl/issues/855#issuecomment-736148086

I think we have the following choices.

  • Make abstract subtype StaticUnitRange for static range and make hierarchy SUnitRange <: StaticUnitRange <: AbstractUnitRange and SOneTo <: StaticUnitRange <: AbstractUnitRange.
  • Move SOneTo <: AbstractUnitRange to SOneTo <: StaticArray.

I prefer the first. Are there any thoughts on this?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the declarations of StaticArrays.SUnitRange and StaticArrays.SOneTo, then review the linked comment in issue #855 alongside Julia's AbstractUnitRange hierarchy. The work is complete when maintainers agree on the subtype design and the declared hierarchy reflects that decision.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
data
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.