JuliaArrays / JuliaArrays/StaticArrays.jl
Convert method for StaticArray shouldn't access data field
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 844
- Forks
- 159
- Avg merge
- 3d 21h
- Merged PRs (30d)
- 3
Description
https://github.com/JuliaArrays/StaticArrays.jl/pull/550 introduces https://github.com/JuliaArrays/StaticArrays.jl/blob/1d5524cc131f8ff9014f4625d68c72a48e35a9df/src/convert.jl#L6 that accesses data for StaticArray but since the latter is an abstract type, there is no reason to believe that it has a data field. This is e.g. invalid for https://github.com/SciML/LabelledArrays.jl/blob/bd9cd38dc9f4ef4eb366c16492fa64ca795eb566/src/slarray.jl#L1-L19
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/convert.jl at the conversion method introduced near line 6 and compare its assumptions with the abstract StaticArray type. Use the linked LabelledArrays example in src/slarray.jl to check behavior for an implementation without a data field. Done means conversion no longer relies on that unsupported assumption and remains valid for StaticArray implementations.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- data
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100