JuliaArrays / JuliaArrays/StaticArrays.jl
`BroadcastStyle` of adjoints and transposes of static vectors seems incorrect
Open
Nobody has claimed this yet.
broadcast
- Dominant language
- Julia
- Stars
- 844
- Forks
- 159
- Avg merge
- 3d 21h
- Merged PRs (30d)
- 3
Description
As in the title, see the following example:
julia> Broadcast.BroadcastStyle(typeof([1,2]'))
Base.Broadcast.DefaultArrayStyle{2}()
julia> Broadcast.BroadcastStyle(typeof((SA[1,2])'))
StaticArrays.StaticArrayStyle{1}()
AFAIK we should have
BroadcastStyle(::Type{<:Transpose{<:Any, <:StaticVector}})= StaticArrayStyle{2}()
BroadcastStyle(::Type{<:Adjoint{<:Any, <:StaticVector}}) = StaticArrayStyle{2}()
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the two Broadcast.BroadcastStyle examples in the issue and locating the existing style definitions for static vectors, transposes, and adjoints. Done means transpose and adjoint static vectors return StaticArrayStyle{2} consistently with the expected behavior, with regression coverage for both cases.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- data
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100