JuliaArrays / JuliaArrays/StaticArrays.jl
Make `eigvals` work with non-Hermitian matrices
Open
Nobody has claimed this yet.
linear-algebra
- Dominant language
- Julia
- Stars
- 844
- Forks
- 159
- Avg merge
- 3d 21h
- Merged PRs (30d)
- 3
Description
Should we be more specific by throwing a DomainError here:
to make it easier to catch these types of errors?
Compare with eigen.jl in LinearAlgebra:
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the referenced line in src/eigen.jl and compare its behavior with the two linked locations in Julia's LinearAlgebra eigen.jl. Confirm how eigvals handles non-Hermitian matrices and define done as using the more specific DomainError behavior requested, with coverage for the resulting error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- data
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100