JuliaArrays / JuliaArrays/StaticArrays.jl
reshape improvements
Open
Nobody has claimed this yet.
cleanup
feature
- Dominant language
- Julia
- Stars
- 844
- Forks
- 159
- Avg merge
- 3d 21h
- Merged PRs (30d)
- 3
Description
A question came up on slack, prompting me to realize that our reshape could be improved:
- With the vastly improved constant propagation in 1.0, we can have an efficient reshape without needing a
Sizewrapper. There's probably other operations for which this is true too. Base.reshapedocs specify that the reshape result shares the underlying storage. Our reshape ofMVectorwithSizedoesn't seem to satisfy that, but it probably should.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the reshape implementation and the MVector behavior described in the issue, then compare them with the Base.reshape documentation on shared storage. Determine whether Size can be removed with current constant propagation and define how reshaping an MVector should preserve its underlying storage; done means both behaviors are implemented and covered by relevant tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- performance
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100