JuliaArrays / JuliaArrays/OffsetArrays.jl

Wrong results using argmin or argmax

Open
#83 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Julia
Stars
212
Forks
45
PR merge metrics
No merged PRs in 30d

Description

Using argmin or argmax along a dimension of an OffsetArray gives wrong results for some offsets
Examples:

using OffsetArrays
A = [1 2; 1 2]
for offset in 0:-1:-3
    A_off = OffsetArray(A, offset, -1)
    A_off[argmin(A_off, dims=2)] |> println
end

produces

[1; ; 1] # Correct
[2; ; 1] # Wrong
[1; ; 2] # Wrong
[1; ; 1] # Correct

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Run the Julia reproduction in the issue with the listed offsets and compare each result with the expected output. Trace how argmin and argmax handle dimensions on OffsetArray values, then add or update coverage for the failing offsets. Done means the shown examples produce the correct results for every offset.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
data
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.