JuliaArrays / JuliaArrays/OffsetArrays.jl

test broken with Julia master

Open
#353 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Julia
Stars
212
Forks
45
PR merge metrics
No merged PRs in 30d

Description

The test
https://github.com/JuliaArrays/OffsetArrays.jl/blob/3b94d643b877732562e8fa18829892af73e790c0/test/runtests.jl#L1898
fails on Julia master because the left-hand side errors (with FillArrays 1.11.0):

julia> using FillArrays

julia> reshape(Fill(2,6), big(2), :)
ERROR: TypeError: in typeassert, expected Tuple{Vararg{Int64}}, got a value of type Tuple{BigInt}
Stacktrace:
 [1] _reshape_uncolon
   @ ./reshapedarray.jl:135 [inlined]
 [2] reshape(parent::Fill{Int64, 1, Tuple{Base.OneTo{Int64}}}, dims::Tuple{BigInt, Colon})
   @ FillArrays ~/.julia/packages/FillArrays/eOEVm/src/FillArrays.jl:269
 [3] reshape(::Fill{Int64, 1, Tuple{Base.OneTo{Int64}}}, ::BigInt, ::Colon)
   @ FillArrays ~/.julia/packages/FillArrays/eOEVm/src/FillArrays.jl:265
 [4] top-level scope
   @ REPL[4]:1

It works, however, with Julia 1.10.4 and 1.11.0-beta1. I don't know if this is an issue for OffsetArrays, for FillArrays or for Julia itself. I simply note that Julia itself doesn't support BigInt arguments for reshape:

julia> reshape(1:2, big(2))
ERROR: MethodError: no method matching reshape(::UnitRange{Int64}, ::BigInt)
The function `reshape` exists, but no method is defined for this combination of argument types.

(tested with Julia 1.10.4, 1.11.0-beta1 and master).

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with test/runtests.jl around line 1898 and reproduce reshape(Fill(2, 6), big(2), :) on the Julia versions and FillArrays 1.11.0 described. Compare the behavior with Julia's native reshape and determine whether OffsetArrays, FillArrays, or Julia owns the incompatibility. Done means the responsible project and a compatible test or fix are identified and verified.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
testing-qa
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.