JuliaArrays / JuliaArrays/FillArrays.jl

More efficient methods for Eye, Fill, Diagonal, etc.

Open
#44 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Julia
Stars
187
Forks
41
Avg merge
17h 29m
Merged PRs (30d)
1

Description

I have collected several such methods here: https://github.com/jlapeyre/IdentityMatrix.jl.

All the methods included show significantly reduced benchmark times. (I have not posted the times yet) Despite the name of the module there are methods for types other than Eye. For instance an efficient method for kron(::AbstractMatrix, ::Diagonal) is almost as fast as one specialized for Eye.

Most of this stuff could be made into PRs to FillArrays.jl and LinearAlgebra.

I don't want to go much further before checking if there are other plans underway.

Also, there is some redundancy of methods with UniformScaling, which might be fixed with some refactoring or traits or the like.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read the methods collected in IdentityMatrix.jl, then compare them with the relevant methods in FillArrays.jl and LinearAlgebra. Determine which efficient Eye, Fill, Diagonal, and kron methods belong in this project, support the changes with benchmark times, and resolve the noted UniformScaling redundancy or refactoring concerns.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
performance
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.