JuliaArrays / JuliaArrays/FillArrays.jl
Support specific `mapreduce`
Open
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 187
- Forks
- 41
- Avg merge
- 17h 29m
- Merged PRs (30d)
- 1
Description
Since sum, maximum, etc. lower to mapreduce, it might be a better idea to support mapreduce(f, op, ::AbstractFill) for op at least in (:max, :min :+, :|, :&) to support maximum, minimum, sum, any and all.
Examples:
Base.mapreduce(f, ::typeof(max), A::Fill) = f(A.value)
Base.mapreduce(f, ::typeof(+), A::Fill) = length(A)*f(A.value)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the existing Base.mapreduce methods for AbstractFill in FillArrays.jl and compare them with the requested max, min, +, |, and & operations. Done means mapreduce(f, op, A::Fill) supports the listed operators and produces the expected results for maximum, minimum, sum, any, and all.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- data
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100