JuliaArrays / JuliaArrays/FillArrays.jl
Add hcat, vcat, and cat methods
Open
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 187
- Forks
- 41
- Avg merge
- 17h 29m
- Merged PRs (30d)
- 1
Description
I recently had a need for these functions. I wrote a quick method (below) for my particular case, but I would be better if they were officially supported.
function Base.hcat(x::Zeros{T,2}...) where T <: Real
all(xx -> xx.size[1] == x[1].size[1], x) || throw(ArgumentError("mismatch in dimension 1"))
n = sum(xx.size[2] for xx in x)
return Zeros(x[1].size[1],n)
end
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the provided Base.hcat implementation for Zeros{T,2} and inspect how the package represents size and concatenation. Add support for hcat, vcat, and cat with appropriate dimension validation, and verify that the requested concatenation cases work.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- data
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100