JuliaArrays / JuliaArrays/FillArrays.jl
Unify `Ones` and `Zeros` as `SFill{0}` and `SFill{k}`?
Open
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 187
- Forks
- 41
- Avg merge
- 17h 29m
- Merged PRs (30d)
- 1
Description
It might make the code cleaner to do:
struct SFill{k, T, N, Axes} <: AbstractFill{T,N}
axes::Axes
end
getindex_value(F::SFill{k,T}) where {k,T} = convert(T,k)
const Ones{T,N,Axes} = SFill{true,T,N,Axes}
const Zeros{T,N,Axes} = SFill{false,T,N,Axes}
It would then be possible to support other special cases. Though whether this machinery is worth it is not clear.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the existing Ones and Zeros definitions and the getindex_value entry point, then compare them with the proposed SFill type and aliases. Determine whether supporting additional special cases justifies this machinery; done requires a decided design and corresponding implementation scope.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- data
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100