JuliaApproximation / JuliaApproximation/GenericFFT.jl
Make in-place functions actually in-place
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 16
- Forks
- 6
- PR merge metrics
- No merged PRs in 30d
Description
Currently, the in-place functions just call the regular functions and copy the output. Examples:
This issue is a reminder to fix that.
It probably won't make much difference when working with BigFloat's because they allocate memory regardless, but it might help significantly with other types (especially in 2D-3D).
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/fft.jl at the generic_fft and generic_dct implementations linked by the issue. Trace how each in-place function currently calls its regular counterpart and copies the output. Done means the in-place functions perform their work in the provided storage without that output-copying approach, while preserving support for the package's arbitrary floating-point types.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- performance
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100