JuliaApproximation / JuliaApproximation/FastTransforms.jl

Add a slow path in ultra2ultra transforms?

Open
#200 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Julia
Stars
281
Forks
27
PR merge metrics
No merged PRs in 30d

Description

The following works on v0.14:

julia> FastTransforms.ultra2ultra(ones(4), 3, 1)
4-element Vector{Float64}:
  4.0
 11.0
  6.0
 10.0

but not on v0.15:

julia> FastTransforms.ultra2ultra(ones(4), 3, 1)
ERROR: AssertionError: abs(λ₁ - λ₂) < 1
Stacktrace:
 [1] plan_th_ultra2ultra!(#unused#::Type{Float64}, ::Tuple{Int64}, λ₁::Int64, λ₂::Int64)
   @ FastTransforms ~/.julia/packages/FastTransforms/jlbLV/src/toeplitzhankel.jl:229
 [2] th_ultra2ultra(::Vector{Float64}, ::Int64, ::Int64)
   @ FastTransforms ~/.julia/packages/FastTransforms/jlbLV/src/toeplitzhankel.jl:286
 [3] ultra2ultra(::Vector{Float64}, ::Int64, ::Vararg{Int64}; z::Base.Pairs{Symbol, Union{}, Tuple{}, NamedTuple{(), Tuple{}}})
   @ FastTransforms ~/.julia/packages/FastTransforms/jlbLV/src/FastTransforms.jl:129
 [4] ultra2ultra(::Vector{Float64}, ::Int64, ::Vararg{Int64})
   @ FastTransforms ~/.julia/packages/FastTransforms/jlbLV/src/FastTransforms.jl:129
 [5] top-level scope
   @ REPL[2]:1

Perhaps there could be a slower path for the general cases, and a faster path for the Toeplitz-Hankel case?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the v0.15 failure with FastTransforms.ultra2ultra(ones(4), 3, 1), then inspect src/toeplitzhankel.jl around plan_th_ultra2ultra! at line 229 and th_ultra2ultra at line 286. Trace the call from src/FastTransforms.jl line 129; done should support the general cases while retaining the faster Toeplitz-Hankel path.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
performance
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.