JuliaApproximation / JuliaApproximation/DomainSets.jl
Move SphericalCoordinate here and use for eltype of spheres?
Open
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 79
- Forks
- 12
- Avg merge
- 6d 22h
- Merged PRs (30d)
- 2
Description
Using SVector{3,T} for the eltype of UnitSphere is problematic since almost no floating point numbers are in it!
Here I have SphericalCoordinate where norm is hard coded to be 1:
I think this would be a better default choice
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the SphericalCoordinate definition in the linked coordinates.jl location, then trace UnitSphere's current SVector{3,T} eltype. Done means the spherical coordinate type is available here and is used as the default sphere eltype without breaking the documented sphere behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 50/100