JuliaAI / JuliaAI/MLJScikitLearnInterface.jl

Scikitlearn clustering methods cleanup

Open
#70 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

help wanted
Dominant language
Julia
Stars
14
Forks
8
PR merge metrics
No merged PRs in 30d

Description

I think these methods could do with a review. Here are a few things that look like issues to me:

  • Some models do not implement a transform method (presumably because python scikit-learn does not) but could, no? Example: DBSCAN

  • Recall that MLJ makes a distinction between report and fitted_params: the latter is for the learned parameters (in this case what is needed to assign a new observation to a class), and everything else goes in report. It seems that in the scikitlearn clustering wraps everything is just lumped into fitted_params. In particular this has led to inconsistency with the Clustering.jl models KMeans and KMedoids (which separate things correctly, as far as I can tell).

cc: @tlienart

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue concerns the scikit-learn clustering wrappers, especially DBSCAN, and compares their transform behavior and fitted_params/report split with Clustering.jl's KMeans and KMedoids. Start by inspecting those wrappers and the referenced model interfaces; done means the clustering methods consistently expose supported transforms and separate learned parameters from report information.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia, scikit-learn
Domain
machine-learning
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.