JuliaAI / JuliaAI/MLJModelInterface.jl

`metadata_pkg` should not set `is_wrapper` to `false` by default

Open
#209 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Julia
Stars
39
Forks
8
PR merge metrics
No merged PRs in 30d

Description

Indeed, this macro should not overload any trait that is not explicitly specified by the user, in my opinion. But in any case, is_wrapper is a model-specific trait, not necessarily pkg-generic.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the metadata_pkg macro and tracing how it handles unspecified traits. Confirm the expected behavior for is_wrapper: it should remain unspecified rather than defaulting to false, and add coverage for that case if the repository has a relevant test location.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.