JuliaAI / JuliaAI/MLJModelInterface.jl
invalid model parameters should either error or keep user arguments
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 39
- Forks
- 8
- PR merge metrics
- No merged PRs in 30d
Description
I noticed today that if a model constructor fails parameter validation it reverts to the default with a warning.
I find this behavior confusing. Normally invalid constructors lead to an error. Alternatively, I can imagine getting frustrated if an overzealous maintainer improperly restricted a parameter range, in which case the thing to do would be to allow the user-provided argument with an error. Either way, reverting to the default seems like a very strange behavior, thoughts?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file, test, or entry point is named. Start by locating model constructor parameter validation and the code that falls back to defaults with a warning, then reproduce the behavior with an invalid parameter. The desired outcome still needs maintainer agreement: error on invalid input or preserve the user argument while reporting the validation failure.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- machine-learning
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100