JuliaAI / JuliaAI/MLJLinearModels.jl

Remove PyCall as a test dependency by factoring out python model runs

Open
#180 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Julia
Stars
86
Forks
15
PR merge metrics
No merged PRs in 30d

Description

For less fragile testing, I propose that the python models, which are currently run in tests to make comparisons with MLJLinearModels, be run separately from tests following the recent model of removing R models, #167.

For example, the code generating python model results now in test/fit/logistic-multinomial.jl is moved to a separate file test/fit/logistic-multinomial_py.jl; running that file serialises the results to a file called test/fit/logistic-multinomial.toml; the remaining DO_COMPARISON code in /fit/logistic-multinomial.jl reads in the data needed for comparisons from the toml file to do the comparisons.

This follows the pattern of the files in test/fit/ now called quantile.jl, quantile.r.jl and quantlile.toml (auto-generated).

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing the current Python model code in test/fit/logistic-multinomial.jl with the separated R-model pattern in test/fit/quantile.jl, test/fit/quantile.r.jl, and test/fit/quantile.toml, while reviewing issue #167. Move Python result generation to test/fit/logistic-multinomial_py.jl and have the comparison test read test/fit/logistic-multinomial.toml; done means comparisons still run without PyCall as a test dependency.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia, python
Domain
testing-qa
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
58/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.