JuliaAI / JuliaAI/MLJIteration.jl
Add logger
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 12
- Forks
- 3
- PR merge metrics
- No merged PRs in 30d
Description
To close https://github.com/JuliaAI/MLJ.jl/issues/1029.
This will be very similar to what we did for MLJTuning in these two PRs:
That is: We add a logger field to the wrapper structs (there are two of them - ProbabilisticTunedModel and DeterministicTunedModel ) just like we did for TunedModel. And then we pass logger on to the Resampler instances , which in this case appears here. In this way, whenever any iteration control (e.g., WithLossDo) accesses a loss, it will also get logged to the specified logger.
Instead of nothing the default value of logger will be MLJBase.default_logger().
cc @pebeto
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Compare the two referenced MLJTuning pull requests first, then inspect the ProbabilisticTunedModel and DeterministicTunedModel wrappers and the Resampler construction in src/core.jl. Done means both wrappers expose a logger defaulting to MLJBase.default_logger() and pass it to their Resampler instances.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- machine-learning, observability
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100