JuliaAI / JuliaAI/DecisionTree.jl
Add option to resample features at nodes without replacement
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 364
- Forks
- 100
- PR merge metrics
- No merged PRs in 30d
Description
Hello, thanks for the nice package.
I was working on an application where I wanted perfect prediction in a classification task and found that I was unable to do that with partial_frac = 1.0, which I did not expect. After some investigation it appears that instances are sampled with repetition when constructing forests. As a result, though N samples are included in each individual tree fit, they almost always include duplicates and are missing other values. See e.g.:
https://github.com/JuliaAI/DecisionTree.jl/blob/master/src/regression/main.jl#L104
julia> rand(1:5, 5)
5-element Vector{Int64}:
5
5
2
2
3
I think it would be preferable if sampling was performed without repetition, ensuring that the partial_frac = 1.0 limit is exact. I don't know if this is the standard convention for random forests, though.
I would be happy to contribute a PR if it's agreed that non-repeated sampling is preferred.
Thank you!
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the sampling code in src/regression/main.jl around line 104 and trace how forests construct their node samples. Clarify the desired random-forest convention and option scope, then verify that sampling without replacement makes partial_frac = 1.0 include every input instance exactly once.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- machine-learning
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100