Juanpe / Juanpe/SkeletonView

Does not work with new UICollectionView Compositional Layout

Open
#321 9 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feature help wanted triaged
Dominant language
Swift
Stars
12.9k
Forks
1.1k
PR merge metrics
No merged PRs in 30d

Description

⚠️ Please fill out this template when filing an issue.

🙏🏼 Please check if it already exists other issue related with yours.
What did you do?

Implemented a UICollectionView using the new Compositional Layout feature.

Then added this to viewDidLoad()

DispatchQueue.main.async {
            self.collectionView.showSkeleton()
        }
What did you expect to happen?

Expected to see the skeleton view applied to the UICollectionView

What happened instead?

I assume that since UICollectionView implementations that use Compositional Layout use diffable datasources instead of implementing the CollecitonView data source the skeleton view was not applied to my collectionview cells.

Steps to reproduce the behavior

Implement a UICollectionView with Compositional Layout and try applying the SkeletonView

SkeletonView Environment

SkeletonView version: SkeletonView (1.8.8)
Xcode version: 11.7
Swift version: 5.2

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the reported UICollectionView Compositional Layout setup and the collectionView.showSkeleton() call from viewDidLoad(). Then inspect SkeletonView's UICollectionView integration and its handling of diffable data sources. Done means skeleton views appear on cells in this layout while existing collection views continue to work.

Written by the indexing model from the issue text.

Assessment

Tech stack
ios, swift
Domain
mobile
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.